Comments on: New date / time / RTC library http://jeelabs.org/2010/02/05/new-date-time-rtc-library/ Computing stuff tied to the physical world Mon, 06 Feb 2012 13:55:24 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: jcw http://jeelabs.org/2010/02/05/new-date-time-rtc-library/#comment-1043 jcw Mon, 08 Feb 2010 10:03:07 +0000 http://news.jeelabs.org/?p=5516#comment-1043 <p>Yes - I see that too for static functions, but not for everything across files. I think the trick is to break up the code into lots and lots of separate source files. But that's very tedious... will need to investigate further one day, thx.</p> Yes – I see that too for static functions, but not for everything across files. I think the trick is to break up the code into lots and lots of separate source files. But that’s very tedious… will need to investigate further one day, thx.

]]> By: PPK http://jeelabs.org/2010/02/05/new-date-time-rtc-library/#comment-1039 PPK Sun, 07 Feb 2010 22:00:19 +0000 http://news.jeelabs.org/?p=5516#comment-1039 <p>GCC that Arduino IDE uses, optimises away functions (methods) and stuff that are not used. So it shouldn't matter if you have to #include Wire.h, or whatever library you do (technically they are not really libraries, but let's pretend they are :).</p> <p>I haven't tested that thoroughfully, but I have noticed that GCC really optimises away functions that I don't call anywhere in my program.</p> GCC that Arduino IDE uses, optimises away functions (methods) and stuff that are not used. So it shouldn’t matter if you have to #include Wire.h, or whatever library you do (technically they are not really libraries, but let’s pretend they are :).

I haven’t tested that thoroughfully, but I have noticed that GCC really optimises away functions that I don’t call anywhere in my program.

]]> By: Sean http://jeelabs.org/2010/02/05/new-date-time-rtc-library/#comment-1030 Sean Fri, 05 Feb 2010 23:12:22 +0000 http://news.jeelabs.org/?p=5516#comment-1030 <p>Awesome, I could use this. I'd already built a more rudimentary, DS1307 specific library for my own use.</p> <p>One nice thing to add (at least for the DS1307) would be simply a function like isRunning to check the CH bit. I'm assuming begin() starts the clock using this same bit ...</p> Awesome, I could use this. I’d already built a more rudimentary, DS1307 specific library for my own use.

One nice thing to add (at least for the DS1307) would be simply a function like isRunning to check the CH bit. I’m assuming begin() starts the clock using this same bit …

]]> By: Mihai GALOS http://jeelabs.org/2010/02/05/new-date-time-rtc-library/#comment-1026 Mihai GALOS Fri, 05 Feb 2010 13:40:47 +0000 http://news.jeelabs.org/?p=5516#comment-1026 <p>..I meant I saw you did make the internal, non-shared class variables private in the demo projects..</p> ..I meant I saw you did make the internal, non-shared class variables private in the demo projects..

]]> By: Mihai GALOS http://jeelabs.org/2010/02/05/new-date-time-rtc-library/#comment-1025 Mihai GALOS Fri, 05 Feb 2010 13:36:11 +0000 http://news.jeelabs.org/?p=5516#comment-1025 <p>Kind of, but you still have public methods. They should be protected. As far as the internal-class variables, I saw that you did make them private.</p> <p>So why do you make all methods public? Is it some kind of interfacing paradigm with C ? Say, I declare a variable and call one of your functions. Will it work if it were <em>only</em> protected, not public?</p> <p>Notice I say variable, not object, because I'm talking C.</p> Kind of, but you still have public methods. They should be protected. As far as the internal-class variables, I saw that you did make them private.

So why do you make all methods public? Is it some kind of interfacing paradigm with C ? Say, I declare a variable and call one of your functions. Will it work if it were only protected, not public?

Notice I say variable, not object, because I’m talking C.

]]> By: jcw http://jeelabs.org/2010/02/05/new-date-time-rtc-library/#comment-1023 jcw Fri, 05 Feb 2010 10:25:07 +0000 http://news.jeelabs.org/?p=5516#comment-1023 <p>I don't understand ... isn't that what I'm doing above?</p> I don’t understand … isn’t that what I’m doing above?

]]> By: Mihai GALOS http://jeelabs.org/2010/02/05/new-date-time-rtc-library/#comment-1022 Mihai GALOS Fri, 05 Feb 2010 09:33:02 +0000 http://news.jeelabs.org/?p=5516#comment-1022 <p>It is recommended that you declare all the memebers of a class as protected or private. That way you can't access a member function/local by using a pointer to it from a non-friend or child class.</p> <p>Just a thought ;) Good work though!</p> It is recommended that you declare all the memebers of a class as protected or private. That way you can’t access a member function/local by using a pointer to it from a non-friend or child class.

Just a thought ;) Good work though!

]]>